Repository navigation
ci: let Blacksmith picks use idle owned side runners - #16021
Closed
teamleaderleo wants to merge 2 commits into
Closed
teamleaderleo wants to merge 2 commits into
teamleaderleo wants to merge 2 commits into
Conversation
- pr_runner_pool.py: release-build is a side lane of a full suite with release_build (exactly when swift-package-tests builds the SDK 15 helper on Blacksmith, so a run still has at most three side lanes). Its priority follows cli-product, ahead of the light lanes, since it saves the most Blacksmith time (a 15-minute universal compile). - Main's full-suite dispatch keeps its side lanes in the plan instead of dropping them, and claude-wrapper, remote-daemon, swift-package-tests and release-build read the pick for main's dispatch the way admission does. - ci-macos.yml release-build (and its CMUX_PRODUCT_RUNNER mirror) takes the side label when owned_jobs names ' release-build ', else MACOS_RUNNER_26. - The self-hosted guard pins the new expressions and route branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
Superseded by the equivalent owned-side routing already on main in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use idle owned side runners for the side lanes of a Blacksmith macOS pick, while keeping the run's root admission and rescue marker tied to the exact owned pool.
Changelog
none
Origin:
/Users/leoli/Projects/cmux-worktrees/owned-side-only(checkoutcmux-worktrees/owned-side-only).Verification
Not run during idle-checkout triage; this draft needs the focused CI picker and self-hosted guard checks.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Lets Blacksmith macOS picks use idle owned side runners for their side lanes (Claude wrapper, remote daemon, Swift package tests, and the new release build), so those jobs leave Blacksmith when owned side runners are free.
side_only_placementinpr_runner_pool.py: pairs a Blacksmith pick's side lanes with the owned pool having the most idle side runners, keeping one runner as margin and preferring light runners; else the lanes keep today's route.release-builda side lane of a full suite withrelease_build, and lets main's full-suite dispatch place its side lanes like a pull request.marker_pool), not just the pick's pool.Written for commit 44f9ad0. Summary will update on new commits.